Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Space ONLY to preview #57

Open
seaspeak opened this issue Nov 5, 2024 · 11 comments
Open

Improvement: Space ONLY to preview #57

seaspeak opened this issue Nov 5, 2024 · 11 comments

Comments

@seaspeak
Copy link

seaspeak commented Nov 5, 2024

The shortcut Ctrl+Space is used to switch input methods.
In File Explorer, typing the first letter of a file name triggers a quick search. For a file named "abc def.png", type "abc d" would locate it quickly.

These are all basic functions of Windows and will trigger Tiefsee preview.

@hbl917070
Copy link
Owner

Normally, when editing a file name in File Explorer, QuickLook should not be triggered. Could you provide more information?

Please share the system version, Tiefsee version, input method name, and the specific steps you followed.

Or are you switching input methods without editing the file name?

@seaspeak
Copy link
Author

seaspeak commented Nov 5, 2024

Not editing the file name.
We could type directly in the File Explorer to search. (no Ctrl+E or Ctrl+F, just typing) You could try typing the first few letters of a file name to quickly locate the file. Therefore, sometimes we need to switch the input method.

Ctrl+Space, Shift+Space, Alt+Space are default Windows shortcuts.

@hbl917070
Copy link
Owner

So it seems that simply modifying it to avoid triggering QuickLook while holding down Ctrl, Shift, or Alt could solve this issue?

@seaspeak
Copy link
Author

seaspeak commented Nov 5, 2024

Yes. press only the spacebar, not any combination of keys.

@seaspeak
Copy link
Author

seaspeak commented Nov 5, 2024

I apologize for oversimplifying the issue. It seems that many input methods send words when you press the spacebar. Is there a way to differentiate between these situations?

@seaspeak
Copy link
Author

seaspeak commented Nov 5, 2024

The project QuickLook: https://github.com/QL-Win/QuickLook
Also use the space to initiate the preview window. It is not triggered by switching input method or sending words.

@hbl917070
Copy link
Owner

I'll submit a version with the modification I mentioned when I have some time later. Then, you can test it to see if it resolves the issue.

@seaspeak
Copy link
Author

seaspeak commented Nov 5, 2024

Please take a look at the project QuickLook. It's not being activated by input method actions. However, when navigating between files using the arrow keys, it's very slow, and a busy cursor is briefly displayed. I hope this isn't caused by its key capturing method, but rather by background loading.

@charles7668
Copy link
Contributor

I think the solution is to wait for the space key to be held for a short time, rather than simply avoiding combination keys.

For example, if I have a file named "abc d.png" and QuickLook is not triggered by the space key, I can type "abc", press "space", then "d" to quickly locate this file.

However, if I enable QuickLook with the space key, typing "abc" and pressing "space" will immediately show the preview window.

@hbl917070
Copy link
Owner

Using the duration of the spacebar press to determine activation does solve the issue, but it adds a 0.3-second delay each time QuickLook is triggered. I think that cost is too high.

@hbl917070
Copy link
Owner

I have already submitted the relevant code.
Theoretically, now Ctrl+Space, Shift+Space, and Alt+Space should not trigger QuickLook.

You can download the Nightly version to test it out.
https://github.com/hbl917070/Tiefsee4/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants