Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.9.0? #80

Closed
musicinmybrain opened this issue Feb 17, 2024 · 6 comments
Closed

Release 1.9.0? #80

musicinmybrain opened this issue Feb 17, 2024 · 6 comments
Assignees
Labels
priority: high impacts proper operation or use of feature important to most users

Comments

@musicinmybrain
Copy link

With HDMF 3.12, the submodule for hdmf-common-schema was updated from 5b4cbb3, i.e. the 1.8.0 release tag, to 4d2ddd6. However:

  • there is no new hdmf-common-schema release tag for 4d2ddd6
  • docs/source/hdmf_common_release_notes.rst has not been updated
  • common/namespace.yaml and docs/source/conf.py still have 1.8.0 as the embedded version number

It would be very helpful, and less confusing, if the practice of making “proper” hdmf-common-schema releases whenever the schemas used in https://github.com/hdmf-dev/hdmf are updated could be resuscitated.

@oruebel oruebel added the priority: high impacts proper operation or use of feature important to most users label Feb 17, 2024
@oruebel
Copy link
Contributor

oruebel commented Feb 17, 2024

Thanks for the issue. This was likely just an oversight during the release.

@rly
Copy link
Contributor

rly commented Feb 17, 2024

Between the 1.8 release and the current head, the schema itself hasn't changed. Only the configuration and documentation files around it have changed (e.g., CI workflows, copyright dates in Legal.txt). Our process in this case is not well defined.

I think the schema version should not be updated if the surrounding files are updated. Perhaps the repo should have a separate versioning system with separate release notes, e.g., the current head would be tagged 1.8.1, and the schema submodule in HDMF should only point to tagged releases of the schema repo (this second part is generally our policy for the submodule, and in retrospect, we should have done this). The double versioning system may be a little confusing but it would be clearer about what's going on.

Alternatively we could update the schema version. I think that suggests to users that the schema has changed, but it probably doesn't matter much to make "extra" releases.

@oruebel what do you think?

@mavaylon1
Copy link
Contributor

mavaylon1 commented Feb 17, 2024

To address @rly question, I don't think the versioning needs to change when there's no schema changes/fixes.

As @rly stated, the update for the newest commit were for dates and an update towards the docs yaml. We don't do version changes for these things. The version number present is correct.

@mavaylon1 mavaylon1 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2024
@musicinmybrain
Copy link
Author

Thanks for the responses, which are quite reasonable – and I must admit I failed to look closely enough to notice that there were no actual schema changes involved.

@oruebel
Copy link
Contributor

oruebel commented Feb 18, 2024

Thanks @rly and @mavaylon1 for the clarification.

I think the schema version should not be updated if the surrounding files are updated.

I agree that basing the version on the schema (the same way we do this in code) is reasonable. Since HDMF is only using the schema, it would be nice (if possible) to have releases of HDMF point to releases of hdmf-common-schema.

@rly
Copy link
Contributor

rly commented Feb 19, 2024

Since HDMF is only using the schema, it would be nice (if possible) to have releases of HDMF point to releases of hdmf-common-schema.

I agree. For the future, let's try to have HDMF point only to releases of the hdmf-common-schema repo, even if the surrounding files have changed, unless there is a strong reason to point to the head instead. I think it will be less confusing that way. (I told @mavaylon1 otherwise when he asked a few weeks ago, but now I think the above policy would be better.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

No branches or pull requests

4 participants