Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contexts removed from kubeconfig is not updated #2541

Open
yolossn opened this issue Nov 7, 2024 · 4 comments · May be fixed by #2570
Open

Contexts removed from kubeconfig is not updated #2541

yolossn opened this issue Nov 7, 2024 · 4 comments · May be fixed by #2570
Assignees
@knrt10
Labels
backend Issues related to the backend bug Something isn't working
Milestone
v0.28.0

Comments

@yolossn
Copy link
Contributor

yolossn commented Nov 7, 2024

Describe the bug

Headlamp watches for changes in the kubeconfigs to keep the contexts in sync with the ones in the kubeconfig files. When a context is added it is reflecting in the UI but when a cluster is removed it is still showing up.

To Reproduce

Steps to reproduce the bug:

  1. Start Headlamp
  2. Add a new context to the kubeconfig file and refresh headlamp
  3. The context shows up in the UI
  4. Remove out a context from the kubeconfig file and refresh headlamp
  5. The removed context still shows up in the UI
@yolossn yolossn added the bug Something isn't working label Nov 7, 2024
@yolossn yolossn added the backend Issues related to the backend label Nov 7, 2024
@dosubot dosubot bot added the frontend Issues related to the frontend label Nov 7, 2024
@yolossn yolossn removed the frontend Issues related to the frontend label Nov 7, 2024
@knrt10
Copy link
Contributor

knrt10 commented Nov 14, 2024 •
edited
Loading

I am able to reproduce this issue, fixing it

@knrt10 knrt10 self-assigned this Nov 14, 2024
knrt10 added a commit that referenced this issue Nov 14, 2024
@knrt10
backend: Fix reloading of clusters in kubeconfig
ed2240c 
When a context was being added and removed from KUBECONFIG file, it was
still visible in UI. This removes the cluster from store and returns
correct list of clusters.

Fixes #2541

Signed-off-by: Kautilya Tripathi <[email protected]>
@knrt10 knrt10 linked a pull request Nov 14, 2024 that will close this issue
Open
knrt10 added a commit that referenced this issue Nov 19, 2024
@knrt10
backend: Fix reloading of clusters in kubeconfig
c2620c4 
When a context was being added and removed from KUBECONFIG file, it was
still visible in UI. This removes the cluster from store and returns
correct list of clusters.

Fixes #2541

Signed-off-by: Kautilya Tripathi <[email protected]>
@joaquimrocha joaquimrocha added this to the v0.27.0 milestone Nov 25, 2024
@joaquimrocha joaquimrocha moved this from Queued to In Progress in Release Plan / Roadmap Dec 11, 2024
@vyncent-t
Copy link
Contributor

not sure if there was a step I missed but when adding another context and refreshing it errored out and didnt render any data for any of the normal resources

@vyncent-t
Copy link
Contributor

I was able to get it to reload with this config

image

@vyncent-t
Copy link
Contributor

also I did not add another user or another cluster field, was able to get it to render and delete in the UI by doing just the context above

@joaquimrocha joaquimrocha modified the milestones: v0.27.0, v0.28.0 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knrt10 knrt10

Labels
backend Issues related to the backend bug Something isn't working
Projects
Release Plan / Roadmap
Status: In Progress
Milestone
v0.28.0
Development

Successfully merging a pull request may close this issue.

backend: Fix reloading of clusters in kubeconfig headlamp-k8s/headlamp
4 participants
@joaquimrocha @yolossn @knrt10 @vyncent-t