Fix Issue #25: Inappropriate Redrawn Multi-Line Asks #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heapwolf#25 Prompts were causing bad user experience in situations where the prompt contains multiple lines. This is because prompt-sync will redraw the prompt as you type, and assumes it only takes up one line. The fix provided prints the whole ask string, before reassigning ask to be only the final line of the prompt. This way, redraws don't affect above lines.
|
One deficiency I noticed after using this for a while: If the users input should cause a line-wrap in their terminal, the original problem (reprint on every keystroke) starts back up. I would suspect this means that the printing itself should be reconsidered, but this commit at least improves the situation, if there are no side-effects. |
|
would very much appreciate a merge here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
#25
Prompts were causing bad user experience in situations where
the prompt contains multiple lines. This is because prompt-sync
will redraw the prompt as you type, and assumes it only takes
up one line.
The fix provided prints the whole ask string, before reassigning
ask to be only the final line of the prompt. This way, redraws
don't affect above lines.
Testing
Wrote and executed a simple script that captures multi-line and single-line prompts.
And Executed:
Potential Side-Effects
I looked over the index.js and didn't see anything concerning, but if there's an expectation that the ask variable is the full string provided by the user, that expectation would be broken beyond line 79.