Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Self-Filed] Windows Support #5

Open
cpsauer opened this issue Nov 1, 2022 · 3 comments
Open

[Self-Filed] Windows Support #5

cpsauer opened this issue Nov 1, 2022 · 3 comments

Comments

@cpsauer
Copy link
Contributor

cpsauer commented Nov 1, 2022

This is a tracking issue for Windows builds, linked to from the README.

If you'd like support for Windows, we'd love your help. It should be a fair bit easier to add support than to do yourself from scratch, we'll help guide, and then your code will work across platforms for free. Plus, you'll be helping everyone out. Please comment here, helping ensure people don't duplicate efforts.

@cpsauer
Copy link
Contributor Author

cpsauer commented Nov 1, 2022

Sketch of how to implement:

CPR should just work out of the box, so the focus will be on getting configuration for libCURL. You'll just need to motify curl.BUILD, referencing the guiding comments therein.

In more detail:

  • Building from source: My read is that curl pretty much just auto-configures on windows, adding config-win32.h automatically, so mostly you'll just want to add a select on "@platforms//os:windows" that omits everything except that first batch of local_defines.
  • Please link to system SSL (USE_SCHANNEL)--and let's omit zlib, at least in the first PR, unless zlib is bundled with the OS and I didn't realize it.
  • Some alternatives: You could also link against a prebuilt windows curl if you want, pulling it down. Alternatively if you think we should be depending on, e.g., winget or some other means of getting dependencies that could be depended on when distributing and installing code compiled with this rule, then we can use that. Or, if libcurl is preinstalled far enough back on windows, we should use that.

@rynewang
Copy link

any updates on this one?

@cpsauer
Copy link
Contributor Author

cpsauer commented Apr 24, 2024

I'm afraid I don't have the bandwidth to knock this one out right now, but that needn't stop you! I'd be happy to take a good PR--outline above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants