Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S-Expression Comments can get Windows/DOS carriage returns embedded in them #41

Open
tealeg opened this issue Nov 20, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@tealeg
Copy link
Contributor

tealeg commented Nov 20, 2018

In the event that someone submits a regula rule that includes Windows/DOS line endings. We'll cope with it without error (hopefully). However, the lexer's scanComment function will currently break on \n and read the preceding \r into the comment string. This doesn't cause any practical problems, but still, it's not quite the right behaviour. We should, instead, explicitly ignore the \r character when lexing a comment.

@tealeg tealeg added bug Something isn't working good first issue Good for newcomers labels Nov 20, 2018
@tealeg tealeg changed the title Comments can get Windows/DOS carriage returns embedded in them S-Expression Comments can get Windows/DOS carriage returns embedded in them Nov 20, 2018
@asdine asdine added this to the v0.7.0 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants