Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Dispatches message content occasionally returns null #75

Open
Stonemercy opened this issue Apr 16, 2024 · 1 comment
Open

[BUG]: Dispatches message content occasionally returns null #75

Stonemercy opened this issue Apr 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working PR ready This issue is approved and ready to be worked on.

Comments

@Stonemercy
Copy link

Stonemercy commented Apr 16, 2024

Link to faulty endpoint

api/v1/dispatches/

The name of your client/application

GWW Bot

Request information

As discussed on Discord this endpoint ocassionally returns null for the message content.
Here is an example
Hard to reproduce

Steps to reproduce

I honestly have no idea, possible ideas that I totally came up with are that an API call to the AH api failing will silently fail 😉

What is expected?

Not null

What is actually happening?

Null

System Info

Any additional comments?

This version of the API is self-hosted. My code has no issue when retrying shortly after (likely after another sync).
Appreciate the work!

@Stonemercy Stonemercy added the bug Something isn't working label Apr 16, 2024
@dealloc
Copy link
Member

dealloc commented Apr 16, 2024

as discussed in Discord, this is most likely the ArrowHead API occasionally returning null for messages.

While there's a retry mechanism for HTTP errors, it should also retry if the received messages contain null.

@dealloc dealloc added the PR ready This issue is approved and ready to be worked on. label Apr 16, 2024
@dealloc dealloc self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR ready This issue is approved and ready to be worked on.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants