Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CowStr #20

Open
kmaasrud opened this issue Mar 7, 2023 · 2 comments · May be fixed by #23
Open

CowStr #20

kmaasrud opened this issue Mar 7, 2023 · 2 comments · May be fixed by #23

Comments

@kmaasrud
Copy link
Collaborator

kmaasrud commented Mar 7, 2023

As mentioned in #19 (comment), making CowStr an actual type instead of an alias would allow us to reuse many common patterns and helper functions. We could also then inline short strings, similar to pulldown_cmark.
@kmaasrud kmaasrud mentioned this issue Mar 7, 2023
Merged
@kmaasrud
Copy link
Collaborator Author

kmaasrud commented Mar 12, 2023 •
edited
Loading

@hellux I'm open to exploring this!

@hellux
Copy link
Owner

hellux commented Mar 12, 2023 via email

kmaasrud added a commit that referenced this issue Mar 15, 2023
@kmaasrud
feat: add custom CowStr type
3f89525 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 15, 2023
@kmaasrud
feat: add custom CowStr type
b54646e 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 16, 2023
@kmaasrud
feat: add custom CowStr type
40b1b34 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 21, 2023
@kmaasrud
feat: add custom CowStr type
efbc56a 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 21, 2023
@kmaasrud
feat: add custom CowStr type
75dcfb2 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 21, 2023
@kmaasrud
feat: add custom CowStr type
f4b9e8d 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 21, 2023
@kmaasrud
feat: add custom CowStr type
4d4d1c1 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 27, 2023
@kmaasrud
feat: add custom CowStr type
7743287 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 27, 2023
@kmaasrud
feat: add custom CowStr type
8fc2736 
Related issue: #20
@kmaasrud kmaasrud linked a pull request Mar 27, 2023 that will close this issue
Custom CowStr type #23
Open
kmaasrud added a commit that referenced this issue Mar 28, 2023
@kmaasrud
feat: add custom CowStr type
b341352 
Related issue: #20
kmaasrud added a commit that referenced this issue Mar 28, 2023
@kmaasrud
feat: add custom CowStr type
41a107a 
Related issue: #20
kmaasrud added a commit that referenced this issue Apr 1, 2023
@kmaasrud
feat: add custom CowStr type
76a1a71 
Related issue: #20
kmaasrud added a commit that referenced this issue Apr 1, 2023
@kmaasrud
feat: add custom CowStr type
18363ea 
Related issue: #20
kmaasrud added a commit that referenced this issue Apr 2, 2023
@kmaasrud
feat: add custom CowStr type
c5814c9 
Related issue: #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom CowStr type hellux/jotdown
2 participants
@hellux @kmaasrud