Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch integer value from JSON #190

Open
artiotest opened this issue Dec 19, 2023 · 2 comments · May be fixed by #492
Open

Fetch integer value from JSON #190

artiotest opened this issue Dec 19, 2023 · 2 comments · May be fixed by #492

Comments

@artiotest
Copy link

Hello,
I'm trying to fetch integer values from AWS SECRET MANAGER json document, but with vals seems not possibile.
Is there a supported solution out of the box ?

Example JSON
{ "secret": { "test": 1 } }

ref+awssecrets://dev?region=eu-central-1#/secret/test

Result using vals eval -f:
expand awssecrets://dev?region=eu-central-1#/secret/test: no value found for key secret/test

Thanks in advance
bersalazar added a commit to bersalazar/vals that referenced this issue Dec 31, 2023
@bersalazar
fix: render int and bool types
cfb391b 
Handles int and bool types when returned as string map value.

Resolves: helmfile#114 and helmfile#190
bersalazar added a commit to bersalazar/vals that referenced this issue Dec 31, 2023
@bersalazar
fix: render int and bool types
bb02e52 
Handles int and bool types when returned as string map value.

Resolves: helmfile#114 and helmfile#190
Signed-off-by: Bernardo Salazar <[email protected]>
@yxxhero
Copy link
Member

yxxhero commented Jan 21, 2024

@artiodev PR is welcome.

@jpascal
Copy link

jpascal commented Apr 11, 2024 •
edited
Loading

I looked through code and found problem, if value of key is not string you will get "no value found for key" error. I have no time to fix it, but I want to do it for support all types (int, string, array). @artiodev

artiodev pushed a commit to artiodev/vals that referenced this issue Aug 8, 2024
helmfile#190-FetchInteger: Fix
807e6f5
@artiodev artiodev linked a pull request Aug 8, 2024 that will close this issue
Open
artiodev pushed a commit to artiodev/vals that referenced this issue Aug 8, 2024
helmfile#190-FetchInteger: Fix
4589846 
Signed-off-by: Gianluca Artioli <[email protected]>
@yxxhero yxxhero linked a pull request Aug 8, 2024 that will close this issue
#190-FetchInteger: Fix #492
Open
artiodev pushed a commit to artiodev/vals that referenced this issue Aug 12, 2024
helmfile#190-FetchInteger: TestCase
7846b4f
artiodev pushed a commit to artiodev/vals that referenced this issue Aug 12, 2024
helmfile#190-FetchInteger: Fix
bf5fe1e 
Signed-off-by: Gianluca Artioli <[email protected]>
artiodev pushed a commit to artiodev/vals that referenced this issue Aug 12, 2024
helmfile#190-FetchInteger: TestCase
f22b744 
Signed-off-by: Gianluca Artioli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#190-FetchInteger: Fix artiodev/vals
3 participants
@jpascal @yxxhero @artiotest