Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units #6

Open
henry2004y opened this issue Apr 23, 2021 · 1 comment
Open

Units #6

henry2004y opened this issue Apr 23, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@henry2004y
Copy link
Owner

There is a unit package in Julia unitful for handling units.
Take a look at that one if you really want to solve the unit problem.
On top of that, UnitfulRecipes.jl provides integrity with Plots.jl. The ideas of how to make abstractions is more important than the unit conversion itself.

Eventually, I want this to replace the old way of utilizing units. This is now partially complete, but not fully tested.

@henry2004y henry2004y added the enhancement New feature or request label Apr 23, 2021
@henry2004y
Copy link
Owner Author

henry2004y commented Apr 28, 2021

Not working yet.

unitx = getunit(data, data.head.variables[1])
causes error on test data contourf plotting.

The problem is that Batsrus has this option of "normalized variables" which are essentially unitless. I will fix this by adding a check in the plotting recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant