Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc on how to create a Finnhub client #4

Closed
wants to merge 4 commits into from
Closed

Fix doc on how to create a Finnhub client #4

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2021 •
edited by henryboisdequin
Loading

Fixes #2

henryboisdequin
henryboisdequin requested changes Apr 17, 2021
View reviewed changes
Copy link
Owner

@henryboisdequin henryboisdequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! In src/lib.rs, you will see the documentation at the top. It would be great if you changed that in the same way where you changed the README.md.

@ghost
Copy link
Author

ghost commented Apr 17, 2021 •
edited by ghost
Loading

Looks good so far! In src/lib.rs, you will see the documentation at the top. It would be great if you changed that in the same way where you changed the README.md.

Indeed just updated this one.

Just have a question, you plan to update the use of the "new" method by "v1" in the test part later or it must be done as a part of this task ?

@henryboisdequin
Copy link
Owner

Looks good so far! In src/lib.rs, you will see the documentation at the top. It would be great if you changed that in the same way where you changed the README.md.

Indeed just updated this one.

Just have a question, you plan to update the use of the "new" method by "v1" in the test part later or it must be done as a part of this task ?

I would love if you could do this as part of this PR! Thanks for reminding me

@henryboisdequin henryboisdequin added the documentation Improvements or additions to documentation label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix docs on how to create a Finnhub Client
3 participants
@henryboisdequin @cubisttriangle @henrytheswimmer