Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosConfigurations example does not invoke nixosConfigurations #182

Open
makoConstruct opened this issue Aug 4, 2023 · 2 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@makoConstruct
Copy link

The example in https://flake.parts/options/flake-parts.html#opt-flake.nixosConfigurations doesn't use nixosConfigurations and so does not demonstrate its use.

@roberth
Copy link
Member

roberth commented Jan 16, 2024

According to module system convention, this is how examples are supposed to be written; for instance, you can just put a value there, and it will be rendered to Nix expression literals. However, this is certainly a valid point.

@roberth roberth added the documentation Improvements or additions to documentation label Jan 16, 2024
@makoConstruct
Copy link
Author

makoConstruct commented Jan 16, 2024

I see. I didn't at all infer, from the title, that the place this value was supposed to be put was nixosConfigurations = , I guess in retrospect I don't know how many readers would have that issue.

But it is generally good to show an example of the thing being used in its usual context.

shymega pushed a commit to shymega/flake-parts that referenced this issue Aug 18, 2024
Avoid clashes with the `terraform` formatter who does a better job at
formatting the ".tf" files, since it has more domain knowledge there.
shymega pushed a commit to shymega/flake-parts that referenced this issue Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants