Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/secretsMap/secretsTouse #49

Open
roberth opened this issue Jan 8, 2022 · 1 comment
Open

s/secretsMap/secretsTouse #49

roberth opened this issue Jan 8, 2022 · 1 comment

Comments

@roberth
Copy link
Member

roberth commented Jan 8, 2022

More descriptive.
Improve docs to clarify that it's required. (no copying of all secrets by default)

@roberth
Copy link
Member Author

roberth commented Nov 15, 2022

hercules-ci-agent 0.9.8 now also reads secretsToUse.
hercules-ci-effects can migrate

  • add secretsToUse to mkEffect
  • write both attrs
  • update the docs
  • later, deprecation warning
  • far future, remove secretsMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant