Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv -> module system #52

Open
1 of 3 tasks
roberth opened this issue Jan 20, 2022 · 1 comment
Open
1 of 3 tasks

stdenv -> module system #52

roberth opened this issue Jan 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@roberth
Copy link
Member

roberth commented Jan 20, 2022

Move away from stdenv and its hooks.
Bash provides mediocre means of composition at best. I've helped someone troubleshoot an error that got its position distorted by eval. It's left us severely disillusioned.
Another potential issue is environment variables leaking from the effect's stdenv into nix-shell/nix develop.

Instead, effects could be composed using the module system allowing the reuse of some NixOS idioms, with the benefits of more type checking and a cleaner process environment.

  • make it work
  • make all effects use modules
  • clean up the public interface a bit
@roberth
Copy link
Member Author

roberth commented Jan 13, 2023

Still keeping some of stdenv, which is useful, but can now start porting things to module style, since #107

@roberth roberth added the enhancement New feature or request label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant