Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider noun-verb naming, commands namespace #66

Open
roberth opened this issue May 18, 2022 · 0 comments
Open

Consider noun-verb naming, commands namespace #66

roberth opened this issue May 18, 2022 · 0 comments

Comments

@roberth
Copy link
Member

roberth commented May 18, 2022

run* was kind of unnecessary and contributors are not inclined to use it. Maybe it somewhat useful to distinguish effects from functions that generate bash commands, like ssh. This could would be better achieved with a namespace, e.g. commands.ssh.

Another potential issue is the the verb is not always fixed. Behavior may vary by branch, which is represented either by runIf(?: #65 ) or by a parameter like runNixOps action = "switch". In the latter case, for which runIf is not suitable, what should the effect function be called? nixops is kind of taken by the package name, but that's not an issue when users call it as effects.nixops { action = _some logic_; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant