Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Subtrees #41

Open
cerico opened this issue Sep 21, 2016 · 3 comments
Open

Subtrees #41

cerico opened this issue Sep 21, 2016 · 3 comments

Comments

@cerico
Copy link

cerico commented Sep 21, 2016

Is it possible to get this working with subtrees. Currently it requires the app.json to be at the toplevel but im looking to push a client app one level down

@gudmundur
Copy link
Contributor

@cerico I'm a little confused, do you mean pipelines or review apps?

@cerico
Copy link
Author

cerico commented Sep 21, 2016

thanks @gudmundur, I think its both! Its in Review Apps, but its also if i 'deploy a branch' from the pipelines view. its fine when running through CircleCi as a 'git subtree push' but im not sure how to tell the pipelines (or review apps) that it should be a subtree

i set an app up here, for testing this out

https://github.com/cerico/review-apps-strategy

@gudmundur
Copy link
Contributor

gudmundur commented Sep 23, 2016

Alright, I think this buildpack might help you out, https://github.com/lstoll/heroku-buildpack-monorepo. It's written by a few people working at Heroku and I know it's being used for a few of our services. Can you give it a try?

I don't think it'll work for multiple review apps, as we rely on the app.json being in the repository root. But the example repository you have should work just fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants