From c289a06f0601fe04fa7f8b020423a5e05ede7f80 Mon Sep 17 00:00:00 2001 From: Hardy Ferentschik Date: Fri, 30 Aug 2024 12:58:49 +0200 Subject: [PATCH] Does not return error in GenerateReplicationTasks when history not found Fixes #6468 Signed-off-by: Hardy Ferentschik --- service/worker/migration/activities.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/service/worker/migration/activities.go b/service/worker/migration/activities.go index af1688fd177..6355cf829f6 100644 --- a/service/worker/migration/activities.go +++ b/service/worker/migration/activities.go @@ -38,6 +38,8 @@ import ( "go.temporal.io/api/workflowservice/v1" "go.temporal.io/sdk/activity" "go.temporal.io/sdk/temporal" + "google.golang.org/protobuf/types/known/timestamppb" + "go.temporal.io/server/api/adminservice/v1" enumsspb "go.temporal.io/server/api/enums/v1" "go.temporal.io/server/api/historyservice/v1" @@ -53,7 +55,6 @@ import ( "go.temporal.io/server/common/persistence" "go.temporal.io/server/common/quotas" "go.temporal.io/server/common/searchattribute" - "google.golang.org/protobuf/types/known/timestamppb" ) type ( @@ -444,8 +445,9 @@ func (a *activities) GenerateReplicationTasks(ctx context.Context, request *gene for i := startIndex; i < len(request.Executions); i++ { we := request.Executions[i] if err := a.generateWorkflowReplicationTask(ctx, rateLimiter, definition.NewWorkflowKey(request.NamespaceID, we.WorkflowId, we.RunId)); err != nil { - if !isNotFoundServiceError(err) { - a.logger.Error("force-replication failed to generate replication task", tag.WorkflowNamespaceID(request.NamespaceID), tag.WorkflowID(we.WorkflowId), tag.WorkflowRunID(we.RunId), tag.Error(err)) + if isNotFoundServiceError(err) { + a.logger.Warn("force-replication failed to generate replication task", tag.WorkflowNamespaceID(request.NamespaceID), tag.WorkflowID(we.WorkflowId), tag.WorkflowRunID(we.RunId), tag.Error(err)) + } else { return err } }