Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFO] readFASTA() potentially returns duplicate peptides #37

Closed
michabirklbauer opened this issue May 3, 2024 · 1 comment
Closed
Assignees
Labels
info Information that might be important wontfix This will not be worked on

Comments

@michabirklbauer
Copy link
Member

This

return MSAMANDA_FASTAPARSER.FASTAParser.DigestFasta(filename, settings, generateDecoys);

potentially yields/returns duplicate peptides and/or peptides that are both target and decoy. This is not really a problem, just something to be aware of!

@michabirklbauer michabirklbauer self-assigned this May 3, 2024
@michabirklbauer michabirklbauer added wontfix This will not be worked on info Information that might be important labels May 3, 2024
@michabirklbauer michabirklbauer pinned this issue May 3, 2024
@michabirklbauer
Copy link
Member Author

Possible fix:

return MSAMANDA_FASTAPARSER.FASTAParser.DigestFasta(filename, settings, generateDecoys).Distinct().ToList();

and implement the following in

public class Peptide

:

public override bool Equals(object obj)
{
    return ToString().Equals(obj.ToString());
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info Information that might be important wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant