Defer import of dask.array to speed up import
#1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpre
force-pushed
the
defer_dask_import
branch
from
6d4a2a2
to
464a8dc
Compare
|
awesome improvement. I have a few suggestions that I will add as comments in the code |
|
@hgrecco, when you have a chance, can you please add your comments to this PR? Thanks! |
|
@hgrecco, would it possible to get this PR reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When various array backends of dask are installed, it can slow down significantly the import time of pint.
Running
python -X importtime -c "from pint import UnitRegistry" 2> pint.txt && tuna pint.txtWithout this PR:
With this PR:
pre-commit run --all-fileswith no errors