Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transformation type protocol #1801 #1805

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Conversation

mikeoconnor0308
Copy link
Contributor

I've manually tested this. Running mypy on tests or examples might be a good way to catch some of these things.

@hgrecco hgrecco merged commit d61f7fc into hgrecco:master Jun 26, 2023
15 of 31 checks passed
@hgrecco
Copy link
Owner

hgrecco commented Jun 26, 2023

Somehow this broke the numpy code, not sure why. Ideas?

@mikeoconnor0308
Copy link
Contributor Author

mikeoconnor0308 commented Jun 28, 2023

i have no idea, i guess something must have been using the Transformation protocol and passing something that should have been a kwarg as a positional argument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hinting: Transformation type incompatible with usage in add_transformation
2 participants