-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dataclass(frozen=True) for compatibility with Python 3.13 (incomplete, needs help) #2037
base: master
Are you sure you want to change the base?
Conversation
Interesting test failure from
|
I'm a bit stuck on what to do next with this one. |
CodSpeed Performance ReportMerging #2037 will not alter performanceComparing Summary
|
While I have been a long proponent of making exception immutable (i.e. frozen when using a dataclasses) this has bit me many times. Do you know what is the change in Python 3.13 that makes this required? |
See: https://github.com/python/cpython/blame/3.13/Lib/dataclasses.py#L1035-L1044 |
I've tried to play with it, but haven't found any good solution with keeping the dataclasses frozen in errors.py. Even if you use functools.cached_property, or other way to avoid mutation within, the errors will eventually get mutated, setting I'm not experienced enough to be able to help here, sorry. |
@hgrecco would it be ok to move them all to |
pre-commit run --all-files
with no errors