Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameters bug in configs #2

Open
SolomidHero opened this issue Jan 7, 2021 · 2 comments
Open

Unused parameters bug in configs #2

SolomidHero opened this issue Jan 7, 2021 · 2 comments

Comments

@SolomidHero
Copy link

In configs there are stage parameter in each config with value 0, 1, 2. It is not used in the main train function of train.py file, but also fails with any command:

CUDA_VISIBLE_DEVICES=0 python train.py -c configs/stage1.json

with traceback:

Traceback (most recent call last):
  File "train.py", line 283, in <module>
    train(num_gpus, args.rank, args.group_name, **train_config)
TypeError: train() got an unexpected keyword argument 'stage'
@SolomidHero
Copy link
Author

Also there are other parameters in configs for stage 2 and 3 that don't make sense in addition to stage, such as mu_quantization, filter_length, win_length and sp_dir.

Also, in stage1 there should be discriminator config defined too, otherwise error for stage 1 training.

And the last one problem: adv_ag and adv_fd should be specified

@SolomidHero SolomidHero changed the title 'stage' parameter bug in config Unused parameters bug in configs Jan 18, 2021
@hhguo
Copy link
Owner

hhguo commented Jan 26, 2021

Thanks for your comments. I will fix them in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants