Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Noto Color Emoji] Choice to include in lean4monaco #2

Open
desaxce opened this issue Sep 6, 2024 · 2 comments
Open

[Noto Color Emoji] Choice to include in lean4monaco #2

desaxce opened this issue Sep 6, 2024 · 2 comments

Comments

@desaxce
Copy link

desaxce commented Sep 6, 2024

Thank your for the constant improvements!

I have a pipeline which leverages lean4monaco and automatically uses the latest published NPM package.
During the week, I noticed a 10s degradation in load times for the Lean4 editor (I was in the countryside with a poor connection, but it was fast earlier last week).

It seems the introduction of the Noto Color Emoji font in e1d06209 accounts for 24MB:
network

VSCode probably comes bundled with those fonts, but web browsers download them.

Could we bring down the load time by switching to a lighter font / working without it?

@joneugster
Copy link
Member

joneugster commented Sep 7, 2024

Absolutely, I included the emoji font as Lean has a few emojis being used, which look bad in JuliaMono's black-and-white. Concretely its mostly about ✅, ❌ (and 💥).

If you have a suggestion for a lighter emoji font, I think we can just switch them out.

@joneugster
Copy link
Member

joneugster commented Sep 7, 2024

I've tried to create my own font with just these emojis, but apparently its not compatible with some devices/browsers. That one is here:

https://github.com/hhu-adam/lean4monaco/tree/main/src/fonts/LeanWeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants