Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize tRPC output middleware #10430

Open
Rotorsoft opened this issue Dec 23, 2024 · 0 comments · May be fixed by #10436
Open

Generalize tRPC output middleware #10430

Rotorsoft opened this issue Dec 23, 2024 · 0 comments · May be fixed by #10436
Assignees
Labels
3 Full day task enhancement New feature or request refinement

Comments

@Rotorsoft
Copy link
Contributor

Description

Description of Changes

  • Refactor output middleware for all tRPC endpoints to support both asynchronous (fire-and-forget) and synchronous actions
  • Generalize the middleware interface to handle different action types uniformly
  • Implementation blocked until signin command PR is merged

Technical Details

  • Current middleware primarily handles asynchronous actions (e.g., fire and forget commit)
  • Need to extend support for sync actions (login)
  • Ensure type safety across all middleware implementations
  • Update all existing tRPC endpoints to use the new middleware interface

Dependencies

  • Blocked by: Signin command PR merge

Test Plan

  • Add unit tests for both sync and async middleware scenarios
  • Test existing endpoints with new middleware implementation
  • Verify backward compatibility
  • Add integration tests for fire-and-forget actions

Deployment Plan

  • Deploy changes after thorough testing
  • Monitor for any regression in existing endpoints

Other Considerations

  • Ensure backward compatibility with existing endpoints
  • Document new middleware interface for future implementations
  • Consider performance implications of middleware changes

Project Owner

No response

Bucket ID

No response

User Stories / Acceptance Criteria

n/a

Design Devlink

No response

Design Screenshot

No response

Additional Context

No response

@Rotorsoft Rotorsoft self-assigned this Dec 23, 2024
@Rotorsoft Rotorsoft added 3 Full day task and removed needs estimate labels Dec 23, 2024
@Rotorsoft Rotorsoft linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Full day task enhancement New feature or request refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant