Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPC creates duplicate cosmos node instead of updating #6658

Closed
mhagel opened this issue Feb 8, 2024 · 1 comment · Fixed by #6712
Closed

Update RPC creates duplicate cosmos node instead of updating #6658

mhagel opened this issue Feb 8, 2024 · 1 comment · Fixed by #6712
Assignees
Labels
3 Full day task bug Something isn't working Cosmos

Comments

@mhagel
Copy link
Contributor

mhagel commented Feb 8, 2024

Describe the bug

In admin-panel, updating a Cosmos-based RPC by community_id creates an additional node, instead of updating the original.

Initial conditions

Environment:

Branch/Release version:

master
Browser:

Wallet:

Reproduction steps

Actual behavior

A new chain node is created

Expected behavior

The original node is updated

Screenshots / Video

Reporter

Additional context

cosmos_chain_id is the canonical ID for a chainNode. This can be leveraged to ensure duplicates are not made.

Related: #6070

@mhagel mhagel added bug Something isn't working 3 Full day task labels Feb 8, 2024
@mhagel mhagel self-assigned this Feb 12, 2024
@mhagel mhagel added the Cosmos label Feb 12, 2024
@mhagel
Copy link
Contributor Author

mhagel commented Feb 12, 2024

@jnaviask I just realized Node-Update isn't implemented yet. I should clarify. Do we want this? And if so, should it only be for Cosmos cases?

In the ETH case, if the node exists, we currently return an Error: "Node already exists" and do not update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Full day task bug Something isn't working Cosmos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant