Add address to results

[Rotorsoft]

Link to Issue

Closes: #10356

Description of Changes

• Fixes query
• Adds unit test

"How We Fixed It"

Test Plan

• Unit tested the FIXME() call.
• CA (click around) tested on local and frack:
  • TODO page

Deployment Plan

1. @timolegros trigger API client release

Other Considerations

[Rotorsoft]

Replaced sequelize query with plain sql and replaced output schema with CommentsView

[timolegros]

Why do we need to modify the query? Passing include_user seems to work to return the addresses. include_reactions fails with 500 error but adding duplicating: true on line 41 and 46 of GetComments.query.ts seems to resolve the error (see this Sequelize issue).

[Rotorsoft]

we are refactoring queries to use plain sql and return "views".... also note that this query is not used by the app, just the external api

[timolegros]

we are refactoring queries to use plain sql and return "views"

We are using view where necessary. I wasn't aware we had decided to convert everything to raw SQL. In this case the Sequelize query is much cleaner IMO.

also note that this query is not used by the app, just the external API

Right so all the more reason to not remove arguments...
Malik is going to use this route to replace existing /viewComments stuff and to paginate comment fetching on the client.

[Rotorsoft]

ok, then we can close this without merging and create another PR to fix the query

[timolegros]

ok, then we can close this without merging and create another PR to fix the query

I'm fine with going with raw query I just hadn't realized we had made that an explicit goal. That said, if we go with raw query we should probably add include_user back.

[Rotorsoft]

ok, then we can close this without merging and create another PR to fix the query

I'm fine with going with raw query I just hadn't realized we had made that an explicit goal. That said, if we go with raw query we should probably add include_user back.

I'm ok with both, but prefer raw queries to have more control over model... sequelize is not bullet proof

I don't see the scenario where you want a comment without the user details included, and the performance hit is minimal

[mzparacha]

Getting some zod errors, but the query works. I have a related PR #10441 where I can get these zod issues fixed.