Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more communities shown on explore page #9538

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #9522

Description of Changes

  • User now sees more than 8 communities when viewing and searching on the Explore Communities page

"How We Fixed It"

removed useRef that was restricting the Virtuoso from showing the correct amount of communities

Test Plan

-go to Explore Communities page
-confirm that you see more than 8 communities
-search for communities using a filter
-if there are more than 8 communities returned, confirm that you now see all of those communities

Copy link
Collaborator

@ilijabojanovic ilijabojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and tested on local

@ilijabojanovic
Copy link
Collaborator

We have other issue for filtering communities which is reported here: #9539

@Israellund Israellund marked this pull request as draft October 11, 2024 18:23
@Israellund
Copy link
Collaborator Author

@mzparacha @masvelio I realized this was just an issue with the overflow-y not being set. I tried to implement VirtuosoGrid but the combination of using overflow-y with the containerRef made the scrolling very glitchy. I replaced the original component that Malik made and now it works as intended. But let me know what you think.

@Israellund Israellund marked this pull request as ready for review October 15, 2024 14:56
@Israellund
Copy link
Collaborator Author

@ilijabojanovic Noted that there is still a bug with the filtering. Will look at that, thank you.

Copy link
Contributor

@mzparacha mzparacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now. Thanks @Israellund

Screen.Recording.2024-10-15.at.8.39.17.PM.mov

@Israellund Israellund merged commit d5bd259 into master Oct 15, 2024
10 checks passed
@Israellund Israellund deleted the israel.9522.explore-only-showing-8-communities branch October 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 unordered communities showing up in /communities
4 participants