Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite user to group #155

Open
williamn opened this issue Dec 3, 2015 · 3 comments
Open

Invite user to group #155

williamn opened this issue Dec 3, 2015 · 3 comments

Comments

@williamn
Copy link

williamn commented Dec 3, 2015

Hello,

I learn that this wrapper does not support Invite user to group. Any plan to add the functionality in near future?

Thanks!
@rberrelleza
Copy link
Contributor

Hi,

No plan in the near future, but this library is pretty much community driven, so PRs are more than welcome (awthanks).

williamn added a commit to williamn/hipchat-rb that referenced this issue Dec 8, 2015
@williamn
added support for invite user to join a group
f53793e 
hipchat#155
@williamn
Copy link
Author

williamn commented Dec 8, 2015

@rberrelleza please review my commit. If it is a good to go, I will create a PR. Thanks

@rberrelleza
Copy link
Contributor

Looks good, thank for the contribution! Could you add a use case for inviting a user that already exists on the group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@williamn @rberrelleza