Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new deployment plan customisation logic for devnet and clarinet console #1368

Open
hugocaillard opened this issue Mar 1, 2024 · 0 comments
Assignees

Comments

@hugocaillard
Copy link
Collaborator

Context

In #1360, we introduced the support of deployment plans for the clarinet-sdk.

The deployment plan behaviour is slightly different than the way it works for devnet:

  • On devnet, if clarinet detects a change in the manifest config, it will ask the user if he want to update the deployment plan. It’ll possibly delete the custom changes made by the user
  • In the sdk, we instead update the deployment plan but retain the custom changes made by the developers, so the update is invisible to the users. The manifest is the source of truth for contract deployment, but everything else can be customized by users.

Follow up on this improvement:

  • Consider using the same logic for other clarinet features (devnet, console)
  • Add a flag to force the usage of the existing deployment plan. Indeed, this current setup wouldn't support some more advanced use case, eg:
-id: 0
  contract-publish
- id: 1
  contract-call
- id: 2
  - contract-publish

It will be rewritten to

- id: 0
  contract-publish
  contract-publish
- id: 1
  contract-call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant