Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a isRecursive meta tag to responses, and as a filter option? #124

Closed
janniks opened this issue Jul 3, 2023 · 3 comments · Fixed by #167
Closed

Add a isRecursive meta tag to responses, and as a filter option? #124

janniks opened this issue Jul 3, 2023 · 3 comments · Fixed by #167
Labels
feature request New feature or request

Comments

@janniks
Copy link
Contributor

janniks commented Jul 3, 2023

Idea, might not be efficient


  • Index recursive inscriptions (scan for text inscriptions that include /content/:iid to other inscriptions)
  • ? Allow filtering by this tag
  • ? Add as a field in inscription response

Related: #123

@janniks janniks added the feature request New feature or request label Jul 3, 2023
@janniks janniks added this to Ordinals Jul 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Ordinals Jul 3, 2023
@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in Ordinals Jul 10, 2023
@chresko
Copy link

chresko commented Jul 19, 2023

@rafaelcr I'm onboard with this addition to the API if we're able to support it. Super useful for searching/filtering, and any consumers of the API who want to support this as well.

@rafaelcr
Copy link
Collaborator

@janniks can you point me to the code you currently use to detect recursion on inscription contents?

@janniks
Copy link
Contributor Author

janniks commented Jul 19, 2023

No code for this exists yet.
Basically the recursive inscription would be text/html (or a similar type, I think some svgs allow relative external elements) which use a relative href/link to /content/:iid or any other link provided under the recursion section of ord. So we would manually have to scan for those text occurrences (might be tricky for edge cases).

@rafaelcr rafaelcr linked a pull request Jul 25, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Ordinals Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants