Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic coding errors in HAPI.py: calculate_parameter_NuVC #37

Open
jmmelko opened this issue Jul 20, 2022 · 0 comments
Open

Basic coding errors in HAPI.py: calculate_parameter_NuVC #37

jmmelko opened this issue Jul 20, 2022 · 0 comments

Comments

@jmmelko
Copy link

jmmelko commented Jul 20, 2022

A simple syntax analysis of hapi.py shows several coding errors: undefined variables and so on

For instance, in calculate_parameter_NuVC:

  • Shift0 is undefined
  • NuVC_species is undefined

I think (but I may be wrong), that this can be solved by:

  • replacing Shift0 by Delta0 (they are the same, just different notations)
  • initializing NuVC_species to 0 and then incrementing it with NuVCDB*(Tref/T)**KappaDB*p and decrementing it with EtaDB*abun*(Gamma0T-1j*Delta0T)

Another error is getLinelist() which calls un inexistent makeQuery

In those cases, raise a NotImplementedError instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant