Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mqtt3 Client stops subscribing on Exception #553

Closed
raddatzk opened this issue Dec 12, 2022 · 2 comments
Closed

Mqtt3 Client stops subscribing on Exception #553

raddatzk opened this issue Dec 12, 2022 · 2 comments
Labels

Comments

@raddatzk
Copy link

Expected behavior

After an exception occurred while consuming an mqtt 3 event, mqtt should continue consuming events

Actual behavior

A reactivex UndeliverableException will be thrown and no more events will be consumed

To Reproduce

Checkout the example repository and follow the steps from the README

Details

  • Affected HiveMQ MQTT Client version(s): 1.3.0
  • Used JVM version: 17.0.5
  • Used OS (name and version): MacOS Ventura
  • Used MQTT version: 3
  • Used MQTT broker (name and version): hivemq/hivemq3:latest
@pglombardo pglombardo added the bug label Dec 12, 2022
@pglombardo
Copy link
Contributor

Hi @raddatzk - thanks for the bug report and great supplementary repo with code!

There should be some protections against breaking the entire event stream although if end user consumer code is throwing exceptions, should that be hidden? Logged?

The best case is if consumer code protects against this as your work-around.

I'll need to give this some thought but in the meantime, this is a good note for other users. Consumer code should be careful to not let unexpected exceptions percolate up.

@pglombardo
Copy link
Contributor

We've filed a feature request in #624 to improve exception handling in the client. I'll close out this issue but if you have any other input/feedback, let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants