Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

Add events to deployment when action is taken #80

Open
gregsidelinger opened this issue Jan 8, 2020 · 3 comments
Open

Add events to deployment when action is taken #80

gregsidelinger opened this issue Jan 8, 2020 · 3 comments

Comments

@gregsidelinger
Copy link
Contributor

It would be nice if an event was generated each time a deployment was scaled up/down.

@gregsidelinger
Copy link
Contributor Author

I was looking into adding this as a feature and it turns out pykube does not have some of the data needed to bind the events to the resource. It is missing the uid and resourceVersion. Since pykube is no longer being developed is there any chance the controller will be moving to the kubernetes python client?

@hjacobs
Copy link
Owner

hjacobs commented Feb 14, 2020

@gregsidelinger that's not an issue with pykube-ng which I maintain. I also generate events in kube-janitor.

@gregsidelinger
Copy link
Contributor Author

my bad. I did not realize the uid was under metadata. I will send a patch some time this weekend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants