Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

Pass more node labels than one #94

Open
tomislater opened this issue Jul 23, 2019 · 3 comments
Open

Pass more node labels than one #94

tomislater opened this issue Jul 23, 2019 · 3 comments

Comments

@tomislater
Copy link
Contributor

Currently, we can only pass one node label, but it should be possible to pass a list of labels (like for system-namespaces).

@click.option(
    "--node-label",
    help="Value for the kubernetes.io/role label (e.g. 'worker' if nodes are labeled kubernetes.io/role=worker)",
    default="worker",
)
@hjacobs
Copy link
Owner

hjacobs commented Jul 23, 2019

SGTM, do you want to contribute a PR?

@tomislater
Copy link
Contributor Author

Yeah!

@tomislater tomislater mentioned this issue Jul 24, 2019
Merged
@tomislater
Copy link
Contributor Author

We can close this guy :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjacobs @tomislater