Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base definition of AU Core Diagnostic Result Observation to AU Base Diagnostic Result Observation (FHIR-47116) #265

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Change base definition of AU Core Diagnostic Result Observation to AU Base Diagnostic Result Observation (FHIR-47116) #265

wants to merge 14 commits into from

Conversation

JayMurdoch
Copy link
Collaborator

@JayMurdoch JayMurdoch commented Oct 10, 2024 •
edited
Loading

This PR fixes FHIR-47116.

  • Changed base definition from Observation to AU Base Diagnostic Result Observation
  • Amended General Requirements page - removed timing and instant from Diagnostic Result Observation Observation.effective[x] - Must Support - Choice of Data Types table as a result of change to Must Support data types from change to base definition
  • change log entry (release 1.0.0 title added, separate PR coming to move necessary entries)

Additional QA issue noted and fixed:

  • from Pathology Result Observation Observation.effective[x] General Requirements page - Must Support - Choice of Data Types. Removed timing and instant from table to reflect MustSupport data types.

@JayMurdoch
Fix for FHIR-47116
209dc1d 
Change base definition to AU Base Diagnostic Result Observation; change log entry.
@JayMurdoch JayMurdoch requested a review from dt-r October 10, 2024 11:35
dt-r
dt-r reviewed Oct 11, 2024
View reviewed changes
input/pagecontent/changes.md Outdated

#### Changes in this version
- Made the following changes to AU Core Diagnostic Result Observation:
- corrected base profile definition from Observation to AU Base Diagnostic Observation [FHIR-47116](https://jira.hl7.org/browse/FHIR-47116)
Copy link
Collaborator

@dt-r dt-r Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make shorter.
- corrected base profile to AU Base Diagnostic Observation [FHIR-47116](https://jira.hl7.org/browse/FHIR-47116)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended.

dt-r
dt-r reviewed Oct 11, 2024
View reviewed changes
input/pagecontent/changes.md Outdated
@@ -1,6 +1,17 @@
### Release 1.0.0
- Expected Publication date: 2025-01
- Expected Publication status: Normative
Copy link
Collaborator

@dt-r dt-r Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publication status matches the status of the spec. AU Core R1 will not be normative.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publication status changed to "TBC".

Copy link
Collaborator Author

@JayMurdoch JayMurdoch Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with @brettesler-ext and @dbojicic 'Working Standard' and amended.

dt-r
dt-r requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@dt-r dt-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. See inline comments.
  2. Missing changed to Must Support documentation for effective[x]

@JayMurdoch JayMurdoch requested review from dt-r and dbojicic and removed request for dt-r October 15, 2024 01:14
@JayMurdoch JayMurdoch changed the title Change base definition of AU Core Diagnostic Result Observation to AU Base Diagnostic Result Observation Change base definition of AU Core Diagnostic Result Observation to AU Base Diagnostic Result Observation (FHIR-47116) Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt-r dt-r dt-r requested changes

@dbojicic dbojicic Awaiting requested review from dbojicic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayMurdoch @dt-r