Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

47 medication request irvine #54

Merged
merged 3 commits into from
Sep 30, 2024
Merged

47 medication request irvine #54

merged 3 commits into from
Sep 30, 2024

Conversation

heathfrankel
Copy link
Collaborator

Added MedicationRequest resource for Patient/irvine-ronny-lawrence with DVA number

This branch is dependent on PR #50 to avoid conflicts in AU Core Sample Data - MedicationRequest.csv, which should be merged before this.

@heathfrankel heathfrankel linked an issue Sep 25, 2024 that may be closed by this pull request
Add MedicationRequest resource(s) for Patient/irvine-ronny-lawrence #47
Closed
@StephThaoOng
Copy link
Collaborator

Hey @heathfrankel, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #54

#54
Reviewed and validated using https://inferno.hl7.org.au Validation Test Suite.
One change suggested - form.text string changed from "Tablet" to "tablet" to align with good practice and ACSQHC standards

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@heathfrankel
Copy link
Collaborator Author

MedicationRequest csv file updated and MedicationRequest-klacid.json regenerated

@heathfrankel heathfrankel merged commit b68d25a into master Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephThaoOng StephThaoOng Awaiting requested review from StephThaoOng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MedicationRequest resource(s) for Patient/irvine-ronny-lawrence
2 participants
@heathfrankel @StephThaoOng