Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark Welo #37

Closed
3 of 8 tasks
Tracked by #19
tabcat opened this issue Dec 29, 2022 · 4 comments
Closed
3 of 8 tasks
Tracked by #19

Benchmark Welo #37

tabcat opened this issue Dec 29, 2022 · 4 comments

Comments

@tabcat
Copy link
Member

tabcat commented Dec 29, 2022

It's important to write benchmarks to understand the capability of the system and to track the effect of changes.

Will add benchmarks with benchmark.js and track them with github-action-benchmark.

@tabcat tabcat changed the title Add benchmarks write benchmarks Dec 29, 2022
@tabcat tabcat mentioned this issue Dec 29, 2022
10 tasks
@tabcat tabcat changed the title write benchmarks Benchmark Welo Jan 4, 2023
@tabcat
Copy link
Member Author

tabcat commented Jan 20, 2023

Because of how Benchmark.js works, either the database operations need to be more consistent or I have to to benchmark the database another way.

@tabcat
Copy link
Member Author

tabcat commented Jan 20, 2023

Benchmarking the important metrics, replica read/write, another way until the database operations are more consistent seems like the best option.

@tabcat
Copy link
Member Author

tabcat commented Jan 20, 2023

It's possible that I was not using Benchmark.js correctly with asynchronous code. Will have to check again.

@tabcat
Copy link
Member Author

tabcat commented Jan 29, 2023

Current benchmarks are good enough to move forward

@tabcat tabcat closed this as completed Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant