Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent code indentation #1

Open
3c1u opened this issue Jan 4, 2021 · 1 comment
Open

Inconsistent code indentation #1

3c1u opened this issue Jan 4, 2021 · 1 comment

Comments

@3c1u
Copy link

3c1u commented Jan 4, 2021

Indentation is mixed/inconsistent in file image_test.c.
https://github.com/hmdlab/frame_diff/blob/master/src/image_test.c#L278-L299

Try clang-format. (e.g. https://github.com/3c1u/dotfiles/blob/master/.clang-format)

@Xilorole
Copy link
Member

We've also tried formatting the whole script, however running automatic corrections didn't entirely work. As you can see in the codes, the initial code has uneven spaces, and line breaks to write the descriptions to make students comfortable to understand.

I was not sure why this code was not changed for years. To have clear codes and have the same informative commenting structure, we'll work on both the script understandability and consistency. Thank you for the recommendation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants