[DLS-10533] migrating from http client to http client v2 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthdas03
force-pushed
the
DLS-10533_Migrating_from_HttpClient_to_HttpClientV2
branch
from
f8ca6bf
to
4c4ae8e
Compare
mahesh-hmrc
reviewed
Oct 22, 2024
test/uk/gov/hmrc/helptosave/modules/UCThresholdOrchestratorSpec.scala
Outdated
Show resolved
Hide resolved
|
Also, now that they are resolved, can we remove the test failure descriptions from the PR comment. Thanks |
Removed them |
mahesh-hmrc
previously approved these changes
Oct 23, 2024
mahesh-hmrc
reviewed
Oct 25, 2024
| ec: ExecutionContext): Future[HttpResponse] = | ||
| http.post(barsEndpoint, bodyJson(request), headers.+("X-Tracking-Id" -> trackingId.toString)) | ||
| ec: ExecutionContext): Future[HttpResponse] = { | ||
| http.post(barsEndpoint).withBody(bodyJson(request)).transform(_.addHttpHeaders(headers, "X-Tracking-Id" -> trackingId.toString)).execute[HttpResponse] |
There was a problem hiding this comment.
Sorry, missed this in previous review.
Would it also make sense to capture the return type as Either[UpstreamErrorResponse, HttpResponse] here? This might need tests being tidied up to reflect the change
While doing that, could you also check on other connectors making sure of the return type and error handling in calling code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.