Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use govuk-focus-colour for timeout-dialog over default browser colour #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gunjam
Copy link
Contributor

@gunjam gunjam commented Oct 25, 2024

The timeout-dialog appears with keyboard focus but is styled with the focus browser default. This is inconsistent with govuk styles but may also have insufficent contrast in some browsers, so I've made this small change to use the govuk style.

Resolves #388

Preview for Firefox 131.0.3 (macOS)

Before After
image image

@hmrc-web-operations
Copy link
Contributor

Thank you for submitting a pull request on this HMRC repository. A member of the HMRC team will review your changes and action accordingly.

HMRC reviewer: please reference this runbook for guidance on how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing focus styles for timeout dialog
2 participants