From 81b1ea605a4940faacb7dbd0356cb36910c78c1c Mon Sep 17 00:00:00 2001 From: besscerule <63503574+besscerule@users.noreply.github.com> Date: Thu, 10 Oct 2024 17:03:36 +0100 Subject: [PATCH 1/2] TGP-2670: updated checklist template for PR --- pull_request_template.md | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 934f23d6..e0eebc7a 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,23 +1,42 @@ # Checklist for developers before reviewing - [ ] I have merged in main - - [ ] I have run `sbt prePR` to run all tests, format and check the code coverage + - [ ] I have run `sbt prePR` to run all tests, format and check the code coverage - [ ] I have written unit tests to cover any code that I wrote, where necessary - - [ ] I have ran the microservices with the latest SM2 config + - [ ] I have linked tickets to any TODOs I have written + - [ ] I have run the microservices with the latest SM2 config - [ ] I have checked all the Acceptance Criteria pass - [ ] I have run the pipeline journey tests - [ ] I have run the local journey tests + - [ ] I have spoken to the QAs about any changes that may need to be made to the journey tests OR no changes to the journey tests are necessary - [ ] I have moved the ticket to Review in Jira - [ ] I have left a message in tgp-prs on slack to alert other Devs that this ticket is ready for review + - [ ] I have checked my PR is not in draft mode + +# Checklist for reviewer 1 +- [ ] I have added an emoji to the relevant message in tgp-prs to show I am reviewing +- [ ] I have checked out the branch +- [ ] I have run the microservices with the latest SM2 config +- [ ] I have checked all the Acceptance Criteria pass +- [ ] I reviewed the code and left comments where necessary +- [ ] I have left a message on the relevant tgp-prs message to show that I have finished reviewing + +# Checklist for reviewer 2 +- [ ] I have added an emoji to the relevant message in tgp-prs to show I am reviewing +- [ ] I have checked out the branch +- [ ] I have run the microservices with the latest SM2 config +- [ ] I have checked all the Acceptance Criteria pass +- [ ] I reviewed the code and left comments where necessary +- [ ] I have left a message on the relevant tgp-prs message to show that I have finished reviewing # Checklist for developers before merging - [ ] The PR has been approved by 2 other developers - [ ] I have merged in main - - [ ] I have run `sbt preMerge' to run all tests, check formatting and code coverage - - [ ] I have ran the microservices with the latest SM2 config + - [ ] I have run `sbt preMerge` to run all tests, check formatting and code coverage + - [ ] I have run the microservices with the latest SM2 config - [ ] I have checked all the Acceptance Criteria pass + - [ ] I have checked that the QAs have merged in any changes to the journey tests - [ ] I have run the pipeline journey tests - [ ] I have run the local journey tests - - [ ] I have spoken to the QAs about any changes that may need to be made to the journey tests OR no changes to the journey tests are necessary # Reminders for developers after merging 1. Wait for pipeline to pass From fd8fa603f0d065b72e2da90d52198ca24c1d4c84 Mon Sep 17 00:00:00 2001 From: besscerule <63503574+besscerule@users.noreply.github.com> Date: Thu, 10 Oct 2024 17:04:39 +0100 Subject: [PATCH 2/2] TGP-2670: added assignment --- pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pull_request_template.md b/pull_request_template.md index e0eebc7a..0b4e3a7c 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,5 +1,6 @@ # Checklist for developers before reviewing - [ ] I have merged in main + - [ ] I have assigned the PR to me - [ ] I have run `sbt prePR` to run all tests, format and check the code coverage - [ ] I have written unit tests to cover any code that I wrote, where necessary - [ ] I have linked tickets to any TODOs I have written