Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Do not use flexEntity in Hoa itself #34

Open
ondrejmirtes opened this issue Jan 25, 2020 · 2 comments
Open

Do not use flexEntity in Hoa itself #34

ondrejmirtes opened this issue Jan 25, 2020 · 2 comments

Comments

@ondrejmirtes
Copy link

Hi,
I'm trying to integrate Hoa regex parser into PHPStan itself, and I've stumbled upon a problem.

Some code from Hoa project itself is using class aliases defined through flexEntity. For example Hoa\File\Generic extends Hoa\Stream, but there are many more.

This makes prefixing the project by php-scoper for using inside scoped PHAR harder. I also suspect it'd make static analysis harder because these symbols aren't known to static reflection.

I'm also skeptical if this feature is needed at all, you could declare a new major version and stop supporting this aliases.

Related: #29

@staabm
Copy link

staabm commented Jan 26, 2020

Ot it seems this is used a lot:
https://github.com/search?l=PHP&q=org%3Ahoaproject+flexEntity&type=Code

@Hywan
Copy link
Member

Hywan commented Jan 27, 2020

This is something we remove in the next version of Hoa. But life happened, and development had slow down. I'll fix this as soon as possible. We all agreed that it brings more troubles than it solves problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants