Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for stats #29

Open
St0wy opened this issue Sep 5, 2022 · 3 comments
Open

Add support for stats #29

St0wy opened this issue Sep 5, 2022 · 3 comments

Comments

@St0wy
Copy link

St0wy commented Sep 5, 2022

In the JS version of the slippi parser, there is a method to get the stats of a game getStats().

It would be nice if peppi had a way to get those.
@hohav
Copy link
Owner

hohav commented Sep 6, 2022

The industrious @NickCondron is working on stats in #11. I expect it'll take time to settle on a final design, but I do want to get stats in soon!

@trstruth
Copy link

hey @NickCondron @hohav I see #11 is now closed, are there still plans to implement stats in this crate? Would y'all accept a PR for it?

@hohav
Copy link
Owner

hohav commented Mar 19, 2024

hey @NickCondron @hohav I see #11 is now closed, are there still plans to implement stats in this crate? Would y'all accept a PR for it?

I'm still interested in stats, although I'm not convinced they belong in this crate. Do you believe they should?

I haven't heard anything about @NickCondron's work on this since #11 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trstruth @hohav @St0wy