Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ActionState values above 0x155 #6

Open
hohav opened this issue Apr 7, 2019 · 1 comment
Open

Handle ActionState values above 0x155 #6

hohav opened this issue Apr 7, 2019 · 1 comment

Comments

@hohav
Copy link
Owner

hohav commented Apr 7, 2019

Our enum values for ActionState at or above 0x155 (341) seem to be wrong. The spreadsheet from which this data came contains the interesting comment "nothing beyond this point is".

According to #4 (comment) these values are character-specific states for special moves, which will require some redesign.

@DustinAlandzes
Copy link
Contributor

it looks like slippi-js only handles 1-21, 50-56, 61, and 62:
https://github.com/project-slippi/slippi-js/blob/master/src/melee/moves.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants