Add typings for Hyperswarm #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "dependencies": { | ||
| "@hyperswarm/network": "^1.2.0", | ||
| "shuffled-priority-queue": "^2.1.0", | ||
| "utp-native": "^2.1.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@hyperswarm/dht": "0.0.1", | ||
| "@types/node": "^13.11.0", |
There was a problem hiding this comment.
Why is this needed and how do you make sure it's up to date with all active Node versions?
|
It’s for the type definitions of classes taken from nodejs like EventEmitter and Socket, as they’re not defined otherwise. |
|
Closing for now as we did tons of updates! @kasperisager maybe this could act as a foundation for our typings? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go. This aims to resolve #55. Basic Types for all the classes. A few descriptions are still missing, but maybe we get that sorted out, I also marked all the methods starting with an underscore as private, not sure if that's right or not.
Maybe you can also complete some of the method and property descriptions since you know much better what they're supposed to do.
Maybe don't merge this yet though, we should wait with this until all the Hyperswarm dependencies have typings right?