Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion key bindings addition #2

Open
frederic-loui opened this issue Apr 15, 2024 · 1 comment
Open

Completion key bindings addition #2

frederic-loui opened this issue Apr 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@frederic-loui
Copy link
Member

frederic-loui commented Apr 15, 2024

Most "industry" CLI use mainly 3 shortcuts in order to trigger CLI completion.

  1. <Tab> character
  2. <Space>character
  3. <?> character (mostly triggered in conjunction with <shift>)

JunOS CLI enables the 3 of them above which has the benefit of:

  • working nicely with reedline Completer and Menu.
  • remove command ambiguity by enforcing complete command syntax at CLI prompt.

-> description handling decided here has to disable <space> completion

IOS-XR/XE enables only [1] and [3] :

  • working nicely with reedline Completer and Menu.
  • let the user write incomplete cli command sh run instead of show running-configuration

-> description handling decided here has to adjust with <space> usage
The command entered needs to be "normalized" during Validation step.

JunOS style seems to be easier (reedline library check needed) to implement (granted that object description case can be easily handled)

@rwestphal rwestphal added the enhancement New feature or request label Apr 18, 2024
@frederic-loui frederic-loui self-assigned this Apr 19, 2024
@frederic-loui
Copy link
Member Author

Completion trigger binding added for <?>.
related to issue #2
please note that <space> trigger will be implemented along side in issue #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants