From cac690c051885ba1d852a3db26e8a9564c183b21 Mon Sep 17 00:00:00 2001 From: Matthias Date: Mon, 7 Oct 2024 22:42:10 +0200 Subject: [PATCH] fix order of steps in release workflow, remove redundant ts-node dependency --- .github/workflows/release.yaml | 24 ++++++++++++------------ package.json | 1 - 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 0ae72ae..d55878e 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -38,18 +38,6 @@ jobs: id: version shell: bash - - name: Retrieve appId - run: | - echo "APP_ID=$(node ./scripts/read-app-id.js)" >> $GITHUB_OUTPUT - id: appId - shell: bash - - - name: Retrieve whether Windows code signing should be attempted - run: | - echo "WINDOWS_CODE_SIGNING=$(node ./scripts/read-windows-code-signing.js)" >> $GITHUB_OUTPUT - id: shouldWindowsCodeSign - shell: bash - - name: install Rust uses: dtolnay/rust-toolchain@1.75.0 @@ -71,6 +59,18 @@ jobs: curl -f -L --output ./pouch/kando.webhapp https://github.com/holochain-apps/kando/releases/download/v0.10.9/kando.webhapp node ./scripts/overwrite-with-test-name.js + - name: Retrieve appId + run: | + echo "APP_ID=$(node ./scripts/read-app-id.js)" >> $GITHUB_OUTPUT + id: appId + shell: bash + + - name: Retrieve whether Windows code signing should be attempted + run: | + echo "WINDOWS_CODE_SIGNING=$(node ./scripts/read-windows-code-signing.js)" >> $GITHUB_OUTPUT + id: shouldWindowsCodeSign + shell: bash + - name: build and upload the app (macOS arm64) if: matrix.platform == 'macos-latest' env: diff --git a/package.json b/package.json index 20f0ede..f385f54 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,6 @@ "ncp": "^2.0.0", "octokit": "4.0.2", "rimraf": "^5.0.1", - "ts-node": "^10.0.0", "typescript": "~4.5.4", "vite": "^4.4.9" }