New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify types of annotators (range, point, spike) by type rather than spec #40

Open

ahuang11 opened this issue Oct 6, 2023 · 0 comments

Contributor

ahuang11 commented Oct 6, 2023

Specifying the spec feels a bit tedious and awkward, or perhaps I don't really understand how to do it without proper docs.

annotator = Annotator(
    {"x": (tuple, "range"), "y": (int, "point")},
    fields=["description"],
    connector=conn,
)

I think it'd be better to have:

annotator = PointAnnotator(
    fields=["description"],
    connector=conn,
)

annotator = RangeAnnotator(
    fields=["description"],
    connector=conn,
)

Or generally

annotator = Annotator(
    kind="range",
    fields=["description"],
    connector=conn,
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment