Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts with fields showing Action selector at all times, even when not specified #23495

Closed
3 of 4 tasks
SeanPM5 opened this issue Dec 29, 2024 · 0 comments · Fixed by #23512
Closed
3 of 4 tasks

Scripts with fields showing Action selector at all times, even when not specified #23495

SeanPM5 opened this issue Dec 29, 2024 · 0 comments · Fixed by #23512
Milestone

Comments

@SeanPM5
Copy link
Contributor

SeanPM5 commented Dec 29, 2024

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.
  • I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

All of my scripts that use fields are showing the Action selector in the script more info dialog even when it's not specified and doesn't belong.

Not only does it mess with the clean appearance, but it's somewhat of a security issue too because it shows up for standard/non-admin user accounts and allows them to run any action.

ScriptFields

Describe the behavior you expected

Don't show Action selector if not specified in the script

Steps to reproduce the issue

  1. Have any script with fields and open the more info dialog for that script. Here's the YAML for the one in my screenshot:
script:

  kitchen_faucet_pour:
    alias: Kitchen Faucet Pour
    description: Pour a custom amount from kitchen faucet
    icon: mdi:faucet-variant
    mode: queued
    fields:

      amount:
        selector:
          number:
            min: 1
            max: 20
            step: 1
        default: 2
        required: true
        name: Dispense Amount
        description: Drag slider to set

      unit:
        selector:
          select:
            options:
              - cups
              - ounces
              - pints
              - quarts
              - gallons
              - liters
              - centiliters
              - deciliters
              - milliliters
            multiple: false
        name: Unit
        required: true
        default: cups
        description: Unit of measurement

    sequence:
      - alias: "Mimic a voice command using Alexa Media Player"
        continue_on_error: true
        action: media_player.play_media
        data:
          entity_id: media_player.kitchen_echo
          media_content_type: custom
          media_content_id: "Ask Delta to dispense {{ amount }} {{ unit }}"

What version of Home Assistant Core has the issue?

2025.1.0b2

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

No response

Which operating system are you using to run this browser?

No response

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@karwosts karwosts added this to the 2025.1 milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants