Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assist dialog lacks keyboard shortcut tip underneath like other Quick Bar dialogs have #23725

Open
3 of 4 tasks
SeanPM5 opened this issue Jan 13, 2025 · 0 comments · May be fixed by #23739
Open
3 of 4 tasks

Assist dialog lacks keyboard shortcut tip underneath like other Quick Bar dialogs have #23725

SeanPM5 opened this issue Jan 13, 2025 · 0 comments · May be fixed by #23739

Comments

@SeanPM5
Copy link
Contributor

SeanPM5 commented Jan 13, 2025

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.
  • I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

2025.1 release added support for the a keyboard shortcut. Unlike the other Quick Bar dialogs, this one doesn't show a keyboard shortcut tip underneath, though. It should say Press 'a' on any page to open the command dialog when it's opened via the button. See comparison below:

Entity dialog when opened via top header bar (note the keyboard shortcut tip underneath):

Screen Shot 2025-01-13 at 1 47 13 PM

Command dialog when opened via the Settings panel (note the keyboard shortcut tip underneath):

Screen Shot 2025-01-13 at 1 47 32 PM

Assist dialog (no keyboard shortcut tip underneath):

Screen Shot 2025-01-13 at 1 47 06 PM

Describe the behavior you expected

For consistency with how the other dialogs behave, it should show a tips message Press 'a' on any page to open the command dialog when it is opened via mouse / button click

Steps to reproduce the issue

  1. Open Assist dialog from the button in top header / nav bar, no keyboard shortcut tip
  2. Now do the same with the entity dialog (right next to assist button), and note the keyboard shortcut tip underneath
  3. Command dialog (when opened from Settings panel main screen /config/dashboard) also shows the keyboard shortcut tip

What version of Home Assistant Core has the issue?

2025.1.2

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue?

No response

Which operating system are you using to run this browser?

No response

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@jpbede jpbede linked a pull request Jan 14, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant